Re: [PATCH 7/7] submodule.c: correctly handle nested submodules in is_submodule_modified

2017-03-30 Thread Junio C Hamano
Jonathan Nieder writes: > Junio C Hamano wrote: > >> Shouldn't this done as part of 4/7 where is_submodule_modified() >> starts reading from the porcelain v2 output? 4/7 does adjust for >> the change from double question mark (porcelain v1) to a single one >> for untracked, but at the same time

Re: [PATCH 7/7] submodule.c: correctly handle nested submodules in is_submodule_modified

2017-03-28 Thread Stefan Beller
On Mon, Mar 27, 2017 at 2:46 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> When a nested submodule has untracked files, it would be reported as >> "modified submodule" in the superproject, because submodules are not >> parsed correctly in is_submodule_modified as they are bucketed into >

Re: [PATCH 7/7] submodule.c: correctly handle nested submodules in is_submodule_modified

2017-03-27 Thread Jonathan Nieder
Junio C Hamano wrote: > Shouldn't this done as part of 4/7 where is_submodule_modified() > starts reading from the porcelain v2 output? 4/7 does adjust for > the change from double question mark (porcelain v1) to a single one > for untracked, but at the same time it needs to prepare for these > '

Re: [PATCH 7/7] submodule.c: correctly handle nested submodules in is_submodule_modified

2017-03-27 Thread Junio C Hamano
Stefan Beller writes: > When a nested submodule has untracked files, it would be reported as > "modified submodule" in the superproject, because submodules are not > parsed correctly in is_submodule_modified as they are bucketed into > the modified pile as "they are not an untracked file". I can

[PATCH 7/7] submodule.c: correctly handle nested submodules in is_submodule_modified

2017-03-24 Thread Stefan Beller
When a nested submodule has untracked files, it would be reported as "modified submodule" in the superproject, because submodules are not parsed correctly in is_submodule_modified as they are bucketed into the modified pile as "they are not an untracked file". Signed-off-by: Stefan Beller --- su

Re: [PATCH 7/7] submodule.c: correctly handle nested submodules in is_submodule_modified

2017-03-24 Thread Stefan Beller
On Fri, Mar 24, 2017 at 4:31 PM, Jonathan Nieder wrote: > > Can this overflow the buffer? Submodule state is supposed to be 4 > characters, so could do > > /* > * T XY : > * T = line type, XY = status, = submodule

Re: [PATCH 7/7] submodule.c: correctly handle nested submodules in is_submodule_modified

2017-03-24 Thread Jonathan Nieder
Stefan Beller wrote: > When a nested submodule has untracked files, it would be reported as > "modified submodule" in the superproject, because submodules are not > parsed correctly in is_submodule_modified as they are bucketed into > the modified pile as "they are not an untracked file". > > Sig

[PATCH 7/7] submodule.c: correctly handle nested submodules in is_submodule_modified

2017-03-24 Thread Stefan Beller
When a nested submodule has untracked files, it would be reported as "modified submodule" in the superproject, because submodules are not parsed correctly in is_submodule_modified as they are bucketed into the modified pile as "they are not an untracked file". Signed-off-by: Stefan Beller --- su

[PATCH 7/7] submodule.c: correctly handle nested submodules in is_submodule_modified

2017-03-23 Thread Stefan Beller
When a nested submodule has untracked files, it would be reported as "modified submodule" in the superproject, because submodules are not parsed correctly in is_submodule_modified as they are bucketed into the modified pile as "they are not an untracked file". Signed-off-by: Stefan Beller --- su