Re: [PATCH 7/6] run-command: block signals between fork and execve

2017-04-13 Thread Eric Wong
Eric Wong wrote: > Brandon Williams wrote: > > On 04/13, Eric Wong wrote: > > > @@ -277,6 +278,8 @@ static void child_err_spew(struct child_process *cmd, > > > struct child_err *cerr) > > > error_errno("exec '%s': cd to '%s' failed", > > > cmd->argv[0], cmd->dir);

Re: [PATCH 7/6] run-command: block signals between fork and execve

2017-04-13 Thread Eric Wong
Brandon Williams wrote: > On 04/13, Eric Wong wrote: > > @@ -277,6 +278,8 @@ static void child_err_spew(struct child_process *cmd, > > struct child_err *cerr) > > error_errno("exec '%s': cd to '%s' failed", > > cmd->argv[0], cmd->dir); > > break; >

Re: [PATCH 7/6] run-command: block signals between fork and execve

2017-04-13 Thread Brandon Williams
On 04/13, Eric Wong wrote: > @@ -277,6 +278,8 @@ static void child_err_spew(struct child_process *cmd, > struct child_err *cerr) > error_errno("exec '%s': cd to '%s' failed", > cmd->argv[0], cmd->dir); > break; > + case CHILD_ERR_SIGPROCMAS

Re: [PATCH 7/6] run-command: block signals between fork and execve

2017-04-13 Thread Brandon Williams
On 04/13, Eric Wong wrote: > Brandon Williams wrote: > > v2 does a bit of restructuring based on comments from reviewers. I took the > > patch by Eric and broke it up and tweaked it a bit to flow better with v2. > > I > > left out the part of Eric's patch which did signal manipulation as I wasn

[PATCH 7/6] run-command: block signals between fork and execve

2017-04-13 Thread Eric Wong
Brandon Williams wrote: > v2 does a bit of restructuring based on comments from reviewers. I took the > patch by Eric and broke it up and tweaked it a bit to flow better with v2. I > left out the part of Eric's patch which did signal manipulation as I wasn't > experienced enough to know what it