Re: [PATCH 6/9] pseudorefs: create and use pseudoref update and delete functions

2015-07-24 Thread Junio C Hamano
David Turner writes: > On Fri, 2015-07-24 at 12:25 -0700, Junio C Hamano wrote: >> David Turner writes: >> >> > Pseudorefs should not be updated through the ref API, because the ref >> > API is for real refs. Instead, use a dedicated pseudoref API. >> > >> > This patch changes writes to CHERRY

Re: [PATCH 6/9] pseudorefs: create and use pseudoref update and delete functions

2015-07-24 Thread David Turner
On Fri, 2015-07-24 at 12:25 -0700, Junio C Hamano wrote: > David Turner writes: > > > Pseudorefs should not be updated through the ref API, because the ref > > API is for real refs. Instead, use a dedicated pseudoref API. > > > > This patch changes writes to CHERRY_PICK_HEAD, REVERT_HEAD, and OR

Re: [PATCH 6/9] pseudorefs: create and use pseudoref update and delete functions

2015-07-24 Thread Junio C Hamano
David Turner writes: > Pseudorefs should not be updated through the ref API, because the ref > API is for real refs. Instead, use a dedicated pseudoref API. > > This patch changes writes to CHERRY_PICK_HEAD, REVERT_HEAD, and ORIG_HEAD. This feels somewhat backwards, and it makes me wonder if it

[PATCH 6/9] pseudorefs: create and use pseudoref update and delete functions

2015-07-23 Thread David Turner
Pseudorefs should not be updated through the ref API, because the ref API is for real refs. Instead, use a dedicated pseudoref API. This patch changes writes to CHERRY_PICK_HEAD, REVERT_HEAD, and ORIG_HEAD. Signed-off-by: David Turner --- builtin/merge.c | 3 +-- builtin/reset.c | 6 ++