Re: [PATCH 6/8] t: simplify loop exit-code status variables

2015-03-25 Thread Jeff King
On Wed, Mar 25, 2015 at 10:27:49AM -0700, Junio C Hamano wrote: > > diff --git a/t/t3060-ls-files-with-tree.sh b/t/t3060-ls-files-with-tree.sh > > index 61c1f53..36b10f7 100755 > > --- a/t/t3060-ls-files-with-tree.sh > > +++ b/t/t3060-ls-files-with-tree.sh > > @@ -25,15 +25,10 @@ test_expect_succe

Re: [PATCH 6/8] t: simplify loop exit-code status variables

2015-03-25 Thread Junio C Hamano
Jeff King writes: > Since shell loops may drop the exit code of failed commands > inside the loop, some tests try to keep track of the status > by setting a variable. This can end up cumbersome and hard > to read; it is much simpler to just exit directly from the > loop using "return 1" (since ea

[PATCH 6/8] t: simplify loop exit-code status variables

2015-03-24 Thread Jeff King
Since shell loops may drop the exit code of failed commands inside the loop, some tests try to keep track of the status by setting a variable. This can end up cumbersome and hard to read; it is much simpler to just exit directly from the loop using "return 1" (since each case is either in a helper