Re: [PATCH 6/7] Remove unused and bad gettext block from git-am

2012-07-21 Thread Jiang Xin
2012/7/22 Stefano Lattarini : > s/message/messages/ I think. > s/are not/do not/ > This "so" is redundant, in light of the earlier "Since". I'd just remove it. Thanks, Stefano. New series of patches are generated and sent to this list. -- Jiang Xin -- To unsubscribe from this list: send the lin

Re: [PATCH 6/7] Remove unused and bad gettext block from git-am

2012-07-21 Thread Stefano Lattarini
On 07/21/2012 05:50 PM, Jiang Xin wrote: > Gettext message > s/message/messages/ I think. > should not start with '-' nor '--'. Since the '-d' and > '--dotest' options are not exist > s/are not/do not/ > in OPTIONS_SPEC variable, > s/OPTIONS_SPEC/the OPTIONS_SPEC/ > so it's safe to remove the bl

[PATCH 6/7] Remove unused and bad gettext block from git-am

2012-07-21 Thread Jiang Xin
Gettext message should not start with '-' nor '--'. Since the '-d' and '--dotest' options are not exist in OPTIONS_SPEC variable, so it's safe to remove the block. Signed-off-by: Jiang Xin --- git-am.sh | 3 --- 1 file changed, 3 deletions(-) diff --git a/git-am.sh b/git-am.sh index 20c1a..cfa6