Re: [PATCH 6/7] Fix tests under GETTEXT_POISON on git-remote

2012-08-22 Thread Junio C Hamano
Jiang Xin writes: > Maybe we should bypass all testcases which calling check_remote_track(). Sounds like it. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 6/7] Fix tests under GETTEXT_POISON on git-remote

2012-08-22 Thread Jiang Xin
2012/8/22 Junio C Hamano : > Which part of the output from "git remote show" does this test > expect to be translated? Specifically, does "tracked" ever get > translated? > > It appears that _(" tracked") is indeed marked for translation in > the source, so how can we expect value in $actual be an

Re: [PATCH 6/7] Fix tests under GETTEXT_POISON on git-remote

2012-08-21 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > From: Jiang Xin > > Use i18n-specific test functions in test scripts for git-remote. > This issue was was introduced in v1.7.10-233-gbb16d5: > > bb16d5 i18n: remote: mark strings for translation > > and been broken under GETTEXT_POISON=YesPlease since. > > Sign

[PATCH 6/7] Fix tests under GETTEXT_POISON on git-remote

2012-08-20 Thread Nguyễn Thái Ngọc Duy
From: Jiang Xin Use i18n-specific test functions in test scripts for git-remote. This issue was was introduced in v1.7.10-233-gbb16d5: bb16d5 i18n: remote: mark strings for translation and been broken under GETTEXT_POISON=YesPlease since. Signed-off-by: Jiang Xin Signed-off-by: Nguyễn Thá