[PATCH 6/6] submodule--helper: introduce new update-module-mode helper

2018-07-18 Thread Stefan Beller
This chews off a bit of the shell part of the update command in git-submodule.sh. When writing the C code, keep in mind that the submodule--helper part will go away eventually and we want to have a C function that is able to determine the submodule update strategy, it as a nicety, make determine_su

Re: [PATCH 6/6] submodule--helper: introduce new update-module-mode helper

2018-07-18 Thread Stefan Beller
On Wed, Jul 18, 2018 at 8:00 AM Derrick Stolee wrote: > > On 7/12/2018 3:47 PM, Stefan Beller wrote: > > + fprintf(stdout, submodule_strategy_to_string(&update_strategy)); > > This line is causing build failures on 'pu' for certain setups: > yeah, will fix in a resend. originally reported at

Re: [PATCH 6/6] submodule--helper: introduce new update-module-mode helper

2018-07-18 Thread Derrick Stolee
On 7/12/2018 3:47 PM, Stefan Beller wrote: + fprintf(stdout, submodule_strategy_to_string(&update_strategy)); This line is causing build failures on 'pu' for certain setups: 2018-07-18T14:53:03.6857987Z builtin/submodule--helper.c: In function ‘module_update_module_mode’: 2018-07-18T14:

[PATCH 6/6] submodule--helper: introduce new update-module-mode helper

2018-07-12 Thread Stefan Beller
This chews off a bit of the shell part of the update command in git-submodule.sh. When writing the C code, keep in mind that the submodule--helper part will go away eventually and we want to have a C function that is able to determine the submodule update strategy, it as a nicety, make determine_su