Re: [PATCH 6/6] daemon: fix length computation in newline stripping

2018-01-26 Thread Jeff King
On Thu, Jan 25, 2018 at 04:38:20PM -0500, Eric Sunshine wrote: > On Wed, Jan 24, 2018 at 7:58 PM, Jeff King wrote: > > When git-daemon gets a pktline request, we strip off any > > trailing newline, replacing it with a NUL. Clients prior to > > 5ad312bede (in git v1.4.0) would send: [...] > > > >

Re: [PATCH 6/6] daemon: fix length computation in newline stripping

2018-01-25 Thread Eric Sunshine
On Wed, Jan 24, 2018 at 7:58 PM, Jeff King wrote: > When git-daemon gets a pktline request, we strip off any > trailing newline, replacing it with a NUL. Clients prior to > 5ad312bede (in git v1.4.0) would send: [...] > > Reported-by: Michael Haggerty > Signed-off-by: Jeff King > --- > diff --gi

[PATCH 6/6] daemon: fix length computation in newline stripping

2018-01-24 Thread Jeff King
When git-daemon gets a pktline request, we strip off any trailing newline, replacing it with a NUL. Clients prior to 5ad312bede (in git v1.4.0) would send: git-upload-pack repo.git\n and we need to strip it off to understand their request. After 5ad312bede, we send the host attribute but no new