Re: [PATCH 57/67] receive-pack: simplify keep_arg computation

2015-09-18 Thread Jeff King
On Fri, Sep 18, 2015 at 02:43:56PM -0400, Eric Sunshine wrote: > On Tue, Sep 15, 2015 at 12:10 PM, Jeff King wrote: > > To generate "--keep=receive-pack $pid on $host", we write > > progressively into a single buffer, which requires keeping > > track of how much we've written so far. But since th

Re: [PATCH 57/67] receive-pack: simplify keep_arg computation

2015-09-18 Thread Eric Sunshine
On Tue, Sep 15, 2015 at 12:10 PM, Jeff King wrote: > To generate "--keep=receive-pack $pid on $host", we write > progressively into a single buffer, which requires keeping > track of how much we've written so far. But since the result > is destined to go into our argv array, we can simply use > ar

[PATCH 57/67] receive-pack: simplify keep_arg computation

2015-09-15 Thread Jeff King
To generate "--keep=receive-pack $pid on $host", we write progressively into a single buffer, which requires keeping track of how much we've written so far. But since the result is destined to go into our argv array, we can simply use argv_array_pushf. Unfortunately we still have to have a static