Re: [PATCH 5.5/22] Add documentation for the index api

2013-07-11 Thread Duy Nguyen
On Thu, Jul 11, 2013 at 6:42 PM, Duy Nguyen wrote: > On Thu, Jul 11, 2013 at 6:30 PM, Thomas Gummerer wrote: >> Duy Nguyen writes: >> Hrm, I played around a bit with this idea, but I couldn't figure out how >> to make it work. For it to work we would still have to load some >> entries in a dire

Re: [PATCH 5.5/22] Add documentation for the index api

2013-07-11 Thread Duy Nguyen
On Thu, Jul 11, 2013 at 6:30 PM, Thomas Gummerer wrote: > Duy Nguyen writes: > >> On Wed, Jul 10, 2013 at 3:10 AM, Thomas Gummerer >> wrote: If you happen to know that certain entries match the given pathspec, you could help the caller avoid match_pathspec'ing again by set a bit

Re: [PATCH 5.5/22] Add documentation for the index api

2013-07-11 Thread Thomas Gummerer
Duy Nguyen writes: > On Wed, Jul 10, 2013 at 3:10 AM, Thomas Gummerer wrote: >>> If you happen to know that certain entries match the given pathspec, >>> you could help the caller avoid match_pathspec'ing again by set a bit >>> in ce_flags. >> >> I currently don't know which entries do match the

Re: [PATCH 5.5/22] Add documentation for the index api

2013-07-09 Thread Duy Nguyen
On Wed, Jul 10, 2013 at 3:10 AM, Thomas Gummerer wrote: >> If you happen to know that certain entries match the given pathspec, >> you could help the caller avoid match_pathspec'ing again by set a bit >> in ce_flags. > > I currently don't know which entries do match the pathspec from just > readin

Re: [PATCH 5.5/22] Add documentation for the index api

2013-07-09 Thread Thomas Gummerer
Duy Nguyen writes: > On Tue, Jul 9, 2013 at 3:54 AM, Thomas Gummerer wrote: >> As promised, a draft for a documentation for the index api as it is in >> this series. > > First of all, it may be a good idea to acknowledge > index_state->cache[] as part of the API for now. Not hiding it > simplifi

Re: [PATCH 5.5/22] Add documentation for the index api

2013-07-09 Thread Duy Nguyen
On Tue, Jul 9, 2013 at 3:54 AM, Thomas Gummerer wrote: > As promised, a draft for a documentation for the index api as it is in > this series. First of all, it may be a good idea to acknowledge index_state->cache[] as part of the API for now. Not hiding it simplifies a few things (no need for new

[PATCH 5.5/22] Add documentation for the index api

2013-07-08 Thread Thomas Gummerer
Document the new index api and add examples of how it should be used instead of the old functions directly accessing the index. Helped-by: Nguyễn Thái Ngọc Duy Signed-off-by: Thomas Gummerer --- Duy Nguyen writes: > Hmm.. I was confused actually (documentation on the api would help > greatly)