I tried all four diff options as listed in the man page of
format-diff. I forget which one I used, but there was no large
difference w.r.t. reviewability if I remember correctly.
On Mon, Dec 22, 2014 at 10:19 AM, Junio C Hamano wrote:
> Stefan Beller writes:
>
>> Notes:
>> This patch is new
Stefan Beller writes:
> Notes:
> This patch is new with v6 of the series
>
> As execute_commands_non_atomic is larger than execute_commands, the diff
> is not moving around execute_commands_non_atomic, but execute_commands.
;-)
Next time perhaps try "--patience" to decide betwe
This way we don't need to declare the function first and implement it
later, but rather we put the implementation directly at the place where
the function was declared.
The reason I did not move it up in the first place is better readability
of the diff as the execute_commands_non_atomic function
3 matches
Mail list logo
