Re: [PATCH 5/6] completion: list existing working trees for 'git worktree' subcommands

2019-10-18 Thread Eric Sunshine
On Fri, Oct 18, 2019 at 11:00 AM SZEDER Gábor wrote: > On Thu, Oct 17, 2019 at 02:08:12PM -0400, Eric Sunshine wrote: > > It is a long-standing To-Do[1] for "git worktree list [--porcelain]" > > to indicate whether a worktree is locked, prunable, etc. Looking at > > the implementation of builtin/w

Re: [PATCH 5/6] completion: list existing working trees for 'git worktree' subcommands

2019-10-18 Thread SZEDER Gábor
On Thu, Oct 17, 2019 at 02:08:12PM -0400, Eric Sunshine wrote: > On Thu, Oct 17, 2019 at 1:35 PM SZEDER Gábor wrote: > > Complete the paths of existing working trees for 'git worktree's > > 'move', 'remove', 'lock', and 'unlock' subcommands. > > [...] > > Arguably 'git worktree unlock ' should onl

Re: [PATCH 5/6] completion: list existing working trees for 'git worktree' subcommands

2019-10-17 Thread Eric Sunshine
On Thu, Oct 17, 2019 at 1:35 PM SZEDER Gábor wrote: > Complete the paths of existing working trees for 'git worktree's > 'move', 'remove', 'lock', and 'unlock' subcommands. > [...] > Arguably 'git worktree unlock ' should only complete locked > working trees, but 'git worktree list --porcelain' do

[PATCH 5/6] completion: list existing working trees for 'git worktree' subcommands

2019-10-17 Thread SZEDER Gábor
Complete the paths of existing working trees for 'git worktree's 'move', 'remove', 'lock', and 'unlock' subcommands. Note that 'git worktree list --porcelain' shows absolute paths, so for simplicity's sake we'll complete full absolute paths as well (as opposed to turning them into relative paths b