Re: [PATCH 5/6] commit-graph: implement file format version 2

2019-03-21 Thread Ævar Arnfjörð Bjarmason
On Wed, Jan 23 2019, Derrick Stolee via GitGitGadget wrote: > graph_version = *(unsigned char*)(data + 4); > - if (graph_version != 1) { > - error(_("graph version %X does not match version %X"), > - graph_version, 1); > + if (!graph_version || graph_v

Re: [PATCH 5/6] commit-graph: implement file format version 2

2019-01-24 Thread Derrick Stolee
On 1/24/2019 4:40 AM, Ævar Arnfjörð Bjarmason wrote: On Wed, Jan 23 2019, Derrick Stolee via GitGitGadget wrote: The new format modifies the header of the commit-graph to solve these problems. We use the 4-byte hash format id, freeing up a byte in our 32-bit alignment to introduce a reachabilit

Re: [PATCH 5/6] commit-graph: implement file format version 2

2019-01-24 Thread Ævar Arnfjörð Bjarmason
On Wed, Jan 23 2019, Derrick Stolee via GitGitGadget wrote: > From: Derrick Stolee > > The commit-graph file format had some shortcomings which we now > correct: > > 1. The hash algorithm was determined by a single byte, instead > of the 4-byte format identifier. > > 2. There was no wa

Re: [PATCH 5/6] commit-graph: implement file format version 2

2019-01-23 Thread Jonathan Tan
> +Version 2: > + > + 1-byte number (C) of "chunks" > + > + 1-byte reachability index version number: > + Currently, the only valid number is 1. > + > + 1-byte (reserved for later use) > + Current clients expect this value to be zero, and will not > + try to read the commit-graph

[PATCH 5/6] commit-graph: implement file format version 2

2019-01-23 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee The commit-graph file format had some shortcomings which we now correct: 1. The hash algorithm was determined by a single byte, instead of the 4-byte format identifier. 2. There was no way to update the reachability index we used. We currently only support gen