Re: [PATCH 5/5] git-send-email: allow edit invalid email address

2012-11-27 Thread Krzysztof Mazur
On Mon, Nov 26, 2012 at 03:50:30PM -0800, Junio C Hamano wrote: > Krzysztof Mazur writes: > > > On Mon, Nov 26, 2012 at 02:58:58PM -0800, Junio C Hamano wrote: > >> Krzysztof Mazur writes: > >> > >> >> Not having this new code inside "elsif (/^e/) { }" feels somewhat > >> >> sloppy, even though

Re: [PATCH 5/5] git-send-email: allow edit invalid email address

2012-11-26 Thread Junio C Hamano
Krzysztof Mazur writes: > On Mon, Nov 26, 2012 at 02:58:58PM -0800, Junio C Hamano wrote: >> Krzysztof Mazur writes: >> >> >> Not having this new code inside "elsif (/^e/) { }" feels somewhat >> >> sloppy, even though it is not *too* bad. Also do we know this >> > >> > ok, I will fix that. >>

Re: [PATCH 5/5] git-send-email: allow edit invalid email address

2012-11-26 Thread Krzysztof Mazur
On Mon, Nov 26, 2012 at 02:58:58PM -0800, Junio C Hamano wrote: > Krzysztof Mazur writes: > > >> Not having this new code inside "elsif (/^e/) { }" feels somewhat > >> sloppy, even though it is not *too* bad. Also do we know this > > > > ok, I will fix that. > > > >> function will never be used

Re: [PATCH 5/5] git-send-email: allow edit invalid email address

2012-11-26 Thread Junio C Hamano
Krzysztof Mazur writes: >> Not having this new code inside "elsif (/^e/) { }" feels somewhat >> sloppy, even though it is not *too* bad. Also do we know this > > ok, I will fix that. > >> function will never be used for addresses other than recipients' (I >> gave a cursory look to see what is do

Re: [PATCH 5/5] git-send-email: allow edit invalid email address

2012-11-26 Thread Junio C Hamano
Krzysztof Mazur writes: > In some cases the user may want to send email with "Cc:" line with > email address we cannot extract. Now we allow user to extract > such email address for us. > > Signed-off-by: Krzysztof Mazur > --- > git-send-email.perl | 9 ++--- > 1 file changed, 6 insertions(

Re: [PATCH 5/5] git-send-email: allow edit invalid email address

2012-11-26 Thread Krzysztof Mazur
On Mon, Nov 26, 2012 at 09:08:34AM -0800, Junio C Hamano wrote: > Krzysztof Mazur writes: > > > In some cases the user may want to send email with "Cc:" line with > > email address we cannot extract. Now we allow user to extract > > such email address for us. > > > > Signed-off-by: Krzysztof Mazu

[PATCH 5/5] git-send-email: allow edit invalid email address

2012-11-22 Thread Krzysztof Mazur
In some cases the user may want to send email with "Cc:" line with email address we cannot extract. Now we allow user to extract such email address for us. Signed-off-by: Krzysztof Mazur --- git-send-email.perl | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/git-send