Re: [PATCH 5/5] commit-graph: add repo arg to graph readers

2018-06-22 Thread Jonathan Tan
> On 6/21/2018 7:06 PM, Jonathan Tan wrote: > >>> diff --git a/commit.c b/commit.c > >>> index 0030e79940..38c12b002f 100644 > >>> --- a/commit.c > >>> +++ b/commit.c > >>> @@ -317,7 +317,7 @@ struct tree *get_commit_tree(const struct commit > >>> *commit) > >>> if (commit->graph_pos == C

Re: [PATCH 5/5] commit-graph: add repo arg to graph readers

2018-06-21 Thread Derrick Stolee
On 6/21/2018 8:33 PM, Derrick Stolee wrote: On 6/21/2018 7:06 PM, Jonathan Tan wrote: diff --git a/commit.c b/commit.c index 0030e79940..38c12b002f 100644 --- a/commit.c +++ b/commit.c @@ -317,7 +317,7 @@ struct tree *get_commit_tree(const struct commit *commit) if (commit->graph_pos

Re: [PATCH 5/5] commit-graph: add repo arg to graph readers

2018-06-21 Thread Derrick Stolee
On 6/21/2018 7:06 PM, Jonathan Tan wrote: diff --git a/commit.c b/commit.c index 0030e79940..38c12b002f 100644 --- a/commit.c +++ b/commit.c @@ -317,7 +317,7 @@ struct tree *get_commit_tree(const struct commit *commit) if (commit->graph_pos == COMMIT_NOT_FROM_GRAPH) BUG(

Re: [PATCH 5/5] commit-graph: add repo arg to graph readers

2018-06-21 Thread Jonathan Tan
> > diff --git a/commit.c b/commit.c > > index 0030e79940..38c12b002f 100644 > > --- a/commit.c > > +++ b/commit.c > > @@ -317,7 +317,7 @@ struct tree *get_commit_tree(const struct commit > > *commit) > > if (commit->graph_pos == COMMIT_NOT_FROM_GRAPH) > > BUG("commit has N

Re: [PATCH 5/5] commit-graph: add repo arg to graph readers

2018-06-21 Thread Stefan Beller
> diff --git a/commit.c b/commit.c > index 0030e79940..38c12b002f 100644 > --- a/commit.c > +++ b/commit.c > @@ -317,7 +317,7 @@ struct tree *get_commit_tree(const struct commit *commit) > if (commit->graph_pos == COMMIT_NOT_FROM_GRAPH) > BUG("commit has NULL tree, but was n

[PATCH 5/5] commit-graph: add repo arg to graph readers

2018-06-21 Thread Jonathan Tan
Add a struct repository argument to the functions in commit-graph.h that read the commit graph. (This commit does not affect functions that write commit graphs.) Because the commit graph functions can now read the commit graph of any repository, the global variable core_commit_graph has been remov