Re: [PATCH 4/7] docs: exclude documentation for commands that have been excluded

On Thu, Apr 18, 2019 at 03:06:56PM +0200, Johannes Schindelin wrote: > > What about command-line options that influence the outcome? It sounds > > like this is the same problem we have in lots of other places (like say, > > compiler flags being updated), that we solve by generating the proposed >

Re: [PATCH 4/7] docs: exclude documentation for commands that have been excluded

Hi Eric & Junio, On Mon, 15 Apr 2019, Eric Sunshine wrote: > On Mon, Apr 15, 2019 at 12:16 AM Eric Sunshine > wrote: > > When composing that email, I originally wrote $(wildcard > > config.mak.autogen) as the suggestion but changed it to the looser > > $(wildcard config.mak*) when I realized th

Re: [PATCH 4/7] docs: exclude documentation for commands that have been excluded

Hi Peff, On Mon, 15 Apr 2019, Jeff King wrote: > On Mon, Apr 15, 2019 at 12:16:51AM -0400, Eric Sunshine wrote: > > > On Sun, Apr 14, 2019 at 11:10 PM Junio C Hamano wrote: > > > Eric Sunshine writes: > > > >> +Documentation/GIT-EXCLUDED-PROGRAMS: Makefile config.mak.uname > > > >> + $(QU

Re: [PATCH 4/7] docs: exclude documentation for commands that have been excluded

Jeff King writes: > What about command-line options that influence the outcome? It sounds > like this is the same problem we have in lots of other places (like say, > compiler flags being updated), that we solve by generating the proposed > file output unconditionally and comparing it to what's o

Re: [PATCH 4/7] docs: exclude documentation for commands that have been excluded

On Mon, Apr 15, 2019 at 12:16:51AM -0400, Eric Sunshine wrote: > On Sun, Apr 14, 2019 at 11:10 PM Junio C Hamano wrote: > > Eric Sunshine writes: > > >> +Documentation/GIT-EXCLUDED-PROGRAMS: Makefile config.mak.uname > > >> + $(QUIET_GEN)echo "EXCLUDED_PROGRAMS := $(EXCLUDED_PROGRAMS)" >$@

Re: [PATCH 4/7] docs: exclude documentation for commands that have been excluded

On Mon, Apr 15, 2019 at 12:16 AM Eric Sunshine wrote: > When composing that email, I originally wrote $(wildcard > config.mak.autogen) as the suggestion but changed it to the looser > $(wildcard config.mak*) when I realized that the developer's own > config.mak probably ought to be a dependency, a

Re: [PATCH 4/7] docs: exclude documentation for commands that have been excluded

On Sun, Apr 14, 2019 at 11:10 PM Junio C Hamano wrote: > Eric Sunshine writes: > >> +Documentation/GIT-EXCLUDED-PROGRAMS: Makefile config.mak.uname > >> + $(QUIET_GEN)echo "EXCLUDED_PROGRAMS := $(EXCLUDED_PROGRAMS)" >$@ > > > > Should this rule also have a dependency upon "config.mak.autoge

Re: [PATCH 4/7] docs: exclude documentation for commands that have been excluded

Eric Sunshine writes: >> diff --git a/Makefile b/Makefile >> @@ -2455,22 +2455,25 @@ $(VCSSVN_LIB): $(VCSSVN_OBJS) >> +Documentation/GIT-EXCLUDED-PROGRAMS: Makefile config.mak.uname >> + $(QUIET_GEN)echo "EXCLUDED_PROGRAMS := $(EXCLUDED_PROGRAMS)" >$@ > > Should this rule also have a depend

Re: [PATCH 4/7] docs: exclude documentation for commands that have been excluded

On Fri, Apr 12, 2019 at 8:00 AM Johannes Schindelin via GitGitGadget wrote: > When building with certain build options, some commands are excluded > from the build. For example, `git-credential-cache` is skipped when > building with `NO_UNIX_SOCKETS`. > > Let's not build or package documentation f

[PATCH 4/7] docs: exclude documentation for commands that have been excluded

From: Johannes Schindelin When building with certain build options, some commands are excluded from the build. For example, `git-credential-cache` is skipped when building with `NO_UNIX_SOCKETS`. Let's not build or package documentation for those excluded commands. This issue was pointed out ri