Re: [PATCH 4/5] submodule--helper: move config-sanitizing to submodule.c

2016-04-28 Thread Lars Schneider
> On 28 Apr 2016, at 15:38, Jeff King wrote: > > These functions should be used by any code which spawns a > submodule process, which may happen in submodule.c (e.g., > for spawning fetch). Let's move them there and make them > public so that submodule--helper can continue to use them. > > Sin

Re: [PATCH 4/5] submodule--helper: move config-sanitizing to submodule.c

2016-04-28 Thread Jeff King
On Thu, Apr 28, 2016 at 08:30:45AM -0700, Stefan Beller wrote: > > +/* > > + * This function is intended as a callback for use with > > + * git_config_from_parameters(). It ignores any config options which > > + * are not suitable for passing along to a submodule, and accumulates the > > rest > >

Re: [PATCH 4/5] submodule--helper: move config-sanitizing to submodule.c

2016-04-28 Thread Stefan Beller
On Thu, Apr 28, 2016 at 6:38 AM, Jeff King wrote: > These functions should be used by any code which spawns a > submodule process, which may happen in submodule.c (e.g., > for spawning fetch). Let's move them there and make them > public so that submodule--helper can continue to use them. > > Sine

[PATCH 4/5] submodule--helper: move config-sanitizing to submodule.c

2016-04-28 Thread Jeff King
These functions should be used by any code which spawns a submodule process, which may happen in submodule.c (e.g., for spawning fetch). Let's move them there and make them public so that submodule--helper can continue to use them. Sine they're now public, let's also provide a basic overview of th