Re: [PATCH 4/5] send-email: fix regression in sendemail.identity parsing

2019-05-29 Thread Johannes Schindelin
Hi Junio & Ævar, On Wed, 22 May 2019, Johannes Schindelin wrote: > On Fri, 17 May 2019, Ævar Arnfjörð Bjarmason wrote: > > > [...] > > +test_expect_success $PREREQ 'sendemail.identity: bool variable fallback' ' > > + git -c sendemail.identity=cloud \ > > + -c sendemail.xmailer=false \

Re: [PATCH 4/5] send-email: fix regression in sendemail.identity parsing

2019-05-22 Thread Johannes Schindelin
Hi Ævar, On Fri, 17 May 2019, Ævar Arnfjörð Bjarmason wrote: > diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh > index 61d484d1a6..890e2874c3 100755 > --- a/t/t9001-send-email.sh > +++ b/t/t9001-send-email.sh > @@ -1228,6 +1228,61 @@ test_expect_success $PREREQ 'sendemail.to works' ' >

Re: [PATCH 4/5] send-email: fix regression in sendemail.identity parsing

2019-05-18 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > Fix a regression in my recent 3494dfd3ee ("send-email: do defaults -> > config -> getopt in that order", 2019-05-09). I missed that the > $identity variable needs to be extracted from the command-line before > we do the config reading, as it determines which con

[PATCH 4/5] send-email: fix regression in sendemail.identity parsing

2019-05-17 Thread Ævar Arnfjörð Bjarmason
Fix a regression in my recent 3494dfd3ee ("send-email: do defaults -> config -> getopt in that order", 2019-05-09). I missed that the $identity variable needs to be extracted from the command-line before we do the config reading, as it determines which config variable we should read first. See [1]