Re: [PATCH 4/5] commit: implement free_commit_graft

2017-08-16 Thread Patryk Obara
Junio C Hamano wrote: > I do not see a need to make this new function extern. Shouldn't it > be made "static" and revert the change to commit.h? Ah, of course :) I was anticipating to find free(graft); in more places throughout code but forgot to get back to it once there was none left. I will

Re: [PATCH 4/5] commit: implement free_commit_graft

2017-08-15 Thread Junio C Hamano
Patryk Obara writes: > Signed-off-by: Patryk Obara > --- > commit.c | 11 --- > commit.h | 1 + > 2 files changed, 9 insertions(+), 3 deletions(-) I do not see a need to make this new function extern. Shouldn't it be made "static" and revert the change to commit.h? > diff --git a/co

Re: [PATCH 4/5] commit: implement free_commit_graft

2017-08-15 Thread Stefan Beller
On Tue, Aug 15, 2017 at 4:49 AM, Patryk Obara wrote: Here is a good place to explain why this is a good patch, (which is not immediately obvious to me at least). > Signed-off-by: Patryk Obara > --- > commit.c | 11 --- > commit.h | 1 + > 2 files changed, 9 insertions(+), 3 deletions(

[PATCH 4/5] commit: implement free_commit_graft

2017-08-15 Thread Patryk Obara
Signed-off-by: Patryk Obara --- commit.c | 11 --- commit.h | 1 + 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/commit.c b/commit.c index 499fb14..6a145f1 100644 --- a/commit.c +++ b/commit.c @@ -109,15 +109,20 @@ static int commit_graft_pos(const unsigned char *sha1)