Re: [PATCH 4/4] lock_ref_sha1_basic: do not die on locking errors

Jeff King wrote: > From: Ronnie Sahlberg > > lock_ref_sha1_basic is inconsistent about when it calls > die() and when it returns NULL to signal an error. This is > annoying to any callers that want to recover from a locking > error. And in addition to the modern transaction stuff, rename_ref() h

[PATCH 4/4] lock_ref_sha1_basic: do not die on locking errors

From: Ronnie Sahlberg lock_ref_sha1_basic is inconsistent about when it calls die() and when it returns NULL to signal an error. This is annoying to any callers that want to recover from a locking error. This seems to be mostly historical accident. It was added in 4bd18c4 (Improve abstraction of