Re: [PATCH 4/4] hook: add a simple first example

2017-07-11 Thread Kaartic Sivaraam
On Tue, 2017-07-11 at 09:03 -0700, Junio C Hamano wrote: > But does it even be useful to enable it? Just for the note, I thought it was considered useful (at least to someone) due to it's presence in the sample script.

Re: [PATCH 4/4] hook: add a simple first example

2017-07-11 Thread Kaartic Sivaraam
On Tue, 2017-07-11 at 09:03 -0700, Junio C Hamano wrote: > But does it even be useful to enable it?  The commented out "git > status" output already lists the modified paths, so I do not think > anything is gained by adding 'diff --cached --name-status' there. The script *doesn't* add the output of

Re: [PATCH 4/4] hook: add a simple first example

2017-07-11 Thread Junio C Hamano
Kaartic Sivaraam writes: > I'm was trying to ask, "Is there any way to change the second example > (diff --name-status) to make it work with "commit --amend" so that it > could be uncommented by default ?" But does it even be useful to enable it? The commented out "git status" output already li

[PATCH 4/4] hook: add a simple first example

2017-07-11 Thread Kaartic Sivaraam
Add a simple example that replaces an outdated example that was removed. This ensures that there's at the least a simple example that illustrates what could be done using the hook just by enabling it. Also, update the documentation. Signed-off-by: Kaartic Sivaraam --- Documentation/githooks.txt

[PATCH 4/4] hook: add a simple first example

2017-07-11 Thread Kaartic Sivaraam
Add a simple example that replaces an outdated example that was removed. This ensures that there's at the least a simple example that illustrates what could be done using the hook just by enabling it. Also, update the documentation. Signed-off-by: Kaartic Sivaraam --- Documentation/githooks.txt

Re: [PATCH 4/4] hook: add a simple first example

2017-07-11 Thread Kaartic Sivaraam
On Mon, 2017-07-10 at 13:02 -0700, Junio C Hamano wrote: > Kaartic Sivaraam writes: > > >  I made an attempt to make the second example work with amending  > >  with the aim of making it suitable for usage out of the box. It > >  seems that it's not easy to make it work as the status of a file >

Re: [PATCH 4/4] hook: add a simple first example

2017-07-10 Thread Junio C Hamano
Kaartic Sivaraam writes: > I made an attempt to make the second example work with amending > with the aim of making it suitable for usage out of the box. It > seems that it's not easy to make it work as the status of a file > cannot be determined correctly when the index while amending > in

[PATCH 4/4] hook: add a simple first example

2017-07-10 Thread Kaartic Sivaraam
Add a simple example that replaces an outdated example that was removed. This ensures that there's at the least a simple example that illustrates what could be done using the hook just by enabling it. Also, update the documentation. Signed-off-by: Kaartic Sivaraam --- I made an attempt to make