Re: [PATCH 4/4] git-remote-mediawiki: use Git's Makefile to build the script

2013-02-08 Thread Jeff King
On Fri, Feb 08, 2013 at 10:13:23AM -0800, Junio C Hamano wrote: > Jeff King writes: > > > On Fri, Feb 08, 2013 at 06:34:37PM +0100, Matthieu Moy wrote: > > > >> Jeff King writes: > >> > >> > That seems much cleaner to me. If done right, it could also let people > >> > put: > >> > > >> > CONT

Re: [PATCH 4/4] git-remote-mediawiki: use Git's Makefile to build the script

2013-02-08 Thread Junio C Hamano
Jeff King writes: > On Fri, Feb 08, 2013 at 06:34:37PM +0100, Matthieu Moy wrote: > >> Jeff King writes: >> >> > That seems much cleaner to me. If done right, it could also let people >> > put: >> > >> > CONTRIB_PERL += contrib/mw-to-git/git-remote-mediawiki >> >> Actually, you can already d

Re: [PATCH 4/4] git-remote-mediawiki: use Git's Makefile to build the script

2013-02-08 Thread Jeff King
On Fri, Feb 08, 2013 at 06:34:37PM +0100, Matthieu Moy wrote: > Jeff King writes: > > > That seems much cleaner to me. If done right, it could also let people > > put: > > > > CONTRIB_PERL += contrib/mw-to-git/git-remote-mediawiki > > Actually, you can already do this: > > SCRIPT_PERL += c

Re: [PATCH 4/4] git-remote-mediawiki: use Git's Makefile to build the script

2013-02-08 Thread Matthieu Moy
Jeff King writes: > That seems much cleaner to me. If done right, it could also let people > put: > > CONTRIB_PERL += contrib/mw-to-git/git-remote-mediawiki Actually, you can already do this: SCRIPT_PERL += contrib/mw-to-git/git-remote-mediawiki.perl probably not by design, but it works!

Re: [PATCH 4/4] git-remote-mediawiki: use Git's Makefile to build the script

2013-02-07 Thread Jeff King
On Thu, Feb 07, 2013 at 11:28:31AM -0800, Junio C Hamano wrote: > Matthieu Moy writes: > > > The configuration of the install directory is not reused from the > > toplevel Makefile: we assume Git is already built, hence just call > > "git --exec-path". This avoids too much surgery in the topleve

Re: [PATCH 4/4] git-remote-mediawiki: use Git's Makefile to build the script

2013-02-07 Thread Junio C Hamano
Matthieu Moy writes: > The configuration of the install directory is not reused from the > toplevel Makefile: we assume Git is already built, hence just call > "git --exec-path". This avoids too much surgery in the toplevel Makefile. > > git-remote-mediawiki.perl can now "use Git;". > > Signed-of

[PATCH 4/4] git-remote-mediawiki: use Git's Makefile to build the script

2013-02-06 Thread Matthieu Moy
The configuration of the install directory is not reused from the toplevel Makefile: we assume Git is already built, hence just call "git --exec-path". This avoids too much surgery in the toplevel Makefile. git-remote-mediawiki.perl can now "use Git;". Signed-off-by: Matthieu Moy --- contrib/mw