Re: [PATCH 3/9] Prepare the builtins for a libified merge_recursive()

2016-07-02 Thread Johannes Schindelin
Hi Junio, On Fri, 1 Jul 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > >> > A truly libified function does not die() just for fun. > >> > >> The sentence is wasting bits. After all, a helper function in > >> run-once-and-exit program does not die() just for fun, either. > > > >

Re: [PATCH 3/9] Prepare the builtins for a libified merge_recursive()

2016-07-01 Thread Junio C Hamano
Johannes Schindelin writes: >> > A truly libified function does not die() just for fun. >> >> The sentence is wasting bits. After all, a helper function in >> run-once-and-exit program does not die() just for fun, either. > > This sentence does not so much target *you* personally as audience, b

Re: [PATCH 3/9] Prepare the builtins for a libified merge_recursive()

2016-07-01 Thread Johannes Schindelin
Hi Junio, On Wed, 29 Jun 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > A truly libified function does not die() just for fun. > > The sentence is wasting bits. After all, a helper function in > run-once-and-exit program does not die() just for fun, either. Given that I had

Re: [PATCH 3/9] Prepare the builtins for a libified merge_recursive()

2016-06-29 Thread Junio C Hamano
Johannes Schindelin writes: > A truly libified function does not die() just for fun. The sentence is wasting bits. After all, a helper function in run-once-and-exit program does not die() just for fun, either. So what's more interesting to know for the readers? > As such, the > recursive merg

[PATCH 3/9] Prepare the builtins for a libified merge_recursive()

2016-06-29 Thread Johannes Schindelin
A truly libified function does not die() just for fun. As such, the recursive merge will convert all die() calls to return -1 instead in the next commits, giving the caller a chance at least to print some helpful message. Let's prepare the builtins for this fatal error condition, even if we do not