Re: [PATCH 3/8] t3305: fix ignored exit code inside loop

2015-03-25 Thread Johan Herland
On Wed, Mar 25, 2015 at 6:28 AM, Jeff King wrote: > When we test deleting notes, we run "git notes remove" in a > loop. However, the exit value of the loop will only reflect > the final note we process. We should break out of the loop > with a failing exit code as soon as we see a problem. > > Not

[PATCH 3/8] t3305: fix ignored exit code inside loop

2015-03-24 Thread Jeff King
When we test deleting notes, we run "git notes remove" in a loop. However, the exit value of the loop will only reflect the final note we process. We should break out of the loop with a failing exit code as soon as we see a problem. Note that we can call "exit 1" here without explicitly creating a