[PATCH 3/7] submodule.c: convert is_submodule_modified to use strbuf_getwholeline

2017-03-24 Thread Stefan Beller
Instead of implementing line reading yet again, make use of our beautiful library function to read one line. By using strbuf_getwholeline instead of strbuf_read, we avoid having to allocate memory for the entire child process output at once. That is, we limit maximum memory usage. Also we can sta

Re: [PATCH 3/7] submodule.c: convert is_submodule_modified to use strbuf_getwholeline

2017-03-24 Thread Stefan Beller
On Fri, Mar 24, 2017 at 3:38 PM, Jonathan Nieder wrote: > It also overlaps work a little better. mentioned >> Once we know all information that we care about, we can terminate >> the child early. In that case we do not care about its exit code as well. > > Should this say something about SIGPIPE

Re: [PATCH 3/7] submodule.c: convert is_submodule_modified to use strbuf_getwholeline

2017-03-24 Thread Jonathan Nieder
Stefan Beller wrote: > Instead of implementing line reading yet again, make use of our beautiful > library function to read one line. By using strbuf_getwholeline instead > of strbuf_read, we avoid having to allocate memory for the entire child > process output at once. That is, we limit maximum

[PATCH 3/7] submodule.c: convert is_submodule_modified to use strbuf_getwholeline

2017-03-24 Thread Stefan Beller
Instead of implementing line reading yet again, make use of our beautiful library function to read one line. By using strbuf_getwholeline instead of strbuf_read, we avoid having to allocate memory for the entire child process output at once. That is, we limit maximum memory usage. Once we know al