Re: [PATCH 3/7] add a test for semantic errors in config files

2014-07-24 Thread Junio C Hamano
Matthieu Moy writes: > Tanay Abhra writes: > > + test_when_finished "mv .git/config.old .git/config" && > + echo "[alias]\n br" >.git/config && >>> >>> Is the use of \n portable? >>> >> >> Yes, you are right, will replace with printf in the next patch. > > ... or a cat >.git/config <<\

Re: [PATCH 3/7] add a test for semantic errors in config files

2014-07-24 Thread Matthieu Moy
Tanay Abhra writes: + test_when_finished "mv .git/config.old .git/config" && + echo "[alias]\n br" >.git/config && >> >> Is the use of \n portable? >> > > Yes, you are right, will replace with printf in the next patch. ... or a cat >.git/config <<\EOF, since this is the construct u

Re: [PATCH 3/7] add a test for semantic errors in config files

2014-07-24 Thread Tanay Abhra
On 7/24/2014 3:41 AM, Junio C Hamano wrote: > Matthieu Moy writes: > >> Tanay Abhra writes: >> >>> +test_expect_success 'check line errors for malformed values' ' >>> + cp .git/config .git/config.old && > > Should this be "mv" not "cp"? You will be overwriting the file from > scratch in th

Re: [PATCH 3/7] add a test for semantic errors in config files

2014-07-23 Thread Junio C Hamano
Matthieu Moy writes: > Tanay Abhra writes: > >> +test_expect_success 'check line errors for malformed values' ' >> +cp .git/config .git/config.old && Should this be "mv" not "cp"? You will be overwriting the file from scratch in the later part of this test. >> +test_when_finished "mv

Re: [PATCH 3/7] add a test for semantic errors in config files

2014-07-23 Thread Matthieu Moy
Tanay Abhra writes: > +test_expect_success 'check line errors for malformed values' ' > + cp .git/config .git/config.old && > + test_when_finished "mv .git/config.old .git/config" && > + echo "[alias]\n br" >.git/config && > + test_expect_code 128 git br 2>result && > + grep "

[PATCH 3/7] add a test for semantic errors in config files

2014-07-23 Thread Tanay Abhra
Semantic errors (for example, for alias.* variables NULL values are not allowed) in configuration files cause a die printing the line number and file name of the offending value. Add a test documenting that such errors cause a die printing the accurate line number and file name. Signed-off-by: Ta