Junio C Hamano wrote:
> You are missing the entire point.
Yeah, okay: I'll drop this patch. I was just saying; I don't feel
strongly about it at all.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at htt
Ramkumar Ramachandra writes:
> Junio C Hamano wrote:
>> The same logic would apply to this semi-nonsense rewrite, no?
>>
>> git diff [[options] [--]] [...]
>>
>> Everything else comes before "--" (if exists) that separates it from
>> the list of pathspecs.
>
> Yeah, except it's sometimes
Ramkumar Ramachandra wrote:
> Hm, I thought it improves readability. I'm trying to say that -- is
> used to separate [...] from [everything else].
I agree with the goal, but I don't think this change achieves it.
Maybe adding gitcli(7) to the SEE ALSO section would work?
Jonathan
--
To unsubscr
Junio C Hamano wrote:
> The same logic would apply to this semi-nonsense rewrite, no?
>
> git diff [[options] [--]] [...]
>
> Everything else comes before "--" (if exists) that separates it from
> the list of pathspecs.
Yeah, except it's sometimes
[[options] [revision range] [--]] [..
Ramkumar Ramachandra writes:
> Junio C Hamano wrote:
>>> -'git diff' [options] [--] [...]::
>>> +'git diff' [options] [[--] [...]]::
>>
>> While the update might be logically more correct, it looks to me
>> that the only end-user visibile effect of it is to make the end
>> result harder to read.
Junio C Hamano wrote:
> While the update might be logically more correct, it looks to me
> that the only end-user visibile effect of it is to make the end
> result harder to read.
Hm, I thought it improves readability. I'm trying to say that -- is
used to separate [...] from [everything else].
--
Ramkumar Ramachandra writes:
> -'git diff' [options] [--] [...]::
> +'git diff' [options] [[--] [...]]::
You can say
"git diff A B --" without any path
"git diff A B pathspec" without any double-dashes
"git diff -- pathspec"
and all three of them are expressed by versions before or
Clarify that "--" is meant to disambiguate paths from the other
options.
Signed-off-by: Ramkumar Ramachandra
---
Documentation/git-diff.txt | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/Documentation/git-diff.txt b/Documentation/git-diff.txt
index 47a
8 matches
Mail list logo
