Re: [PATCH 3/5] diff: acknowledge --submodule=short command-line option

2012-10-07 Thread Jens Lehmann
Am 07.10.2012 21:49, schrieb Jens Lehmann: > I forgot to mention that testing submodule_format_cfg would have to > happen in cmd_diff() (between reading the config and parsing the > command line options) instead of builtin_diff(). Something like this > should do the trick (untested): > > diff --gi

Re: [PATCH 3/5] diff: acknowledge --submodule=short command-line option

2012-10-07 Thread Jens Lehmann
Am 07.10.2012 17:22, schrieb Ramkumar Ramachandra: > Jens Lehmann wrote: >> Am 02.10.2012 18:51, schrieb Ramkumar Ramachandra: >>> Currently, the diff code does not differentiate between an explicit >>> '--submodule=short' being passed, and no submodule option being passed >>> on the command line.

Re: [PATCH 3/5] diff: acknowledge --submodule=short command-line option

2012-10-07 Thread Ramkumar Ramachandra
Jens Lehmann wrote: > Am 02.10.2012 18:51, schrieb Ramkumar Ramachandra: >> Currently, the diff code does not differentiate between an explicit >> '--submodule=short' being passed, and no submodule option being passed >> on the command line. Making this differentiation will be important >> when th

Re: [PATCH 3/5] diff: acknowledge --submodule=short command-line option

2012-10-02 Thread Jens Lehmann
Am 02.10.2012 18:51, schrieb Ramkumar Ramachandra: > Currently, the diff code does not differentiate between an explicit > '--submodule=short' being passed, and no submodule option being passed > on the command line. Making this differentiation will be important > when the command-line option can

[PATCH 3/5] diff: acknowledge --submodule=short command-line option

2012-10-02 Thread Ramkumar Ramachandra
Currently, the diff code does not differentiate between an explicit '--submodule=short' being passed, and no submodule option being passed on the command line. Making this differentiation will be important when the command-line option can be used to override a "diff.submoduleFormat" configuration