Stefan Beller writes:
> Exactly, sorry for not writing my chain of thoughts down completely.
>
> To make them reusable, I'd assume we want them to be easy to
> understand, and by using a well known way in git it is easier to
> understand.
I already said I do not care too deeply either way, but I
On Fri, Mar 25, 2016 at 10:25 AM, Junio C Hamano wrote:
> Junio C Hamano writes:
>
>> The way all the subcommand written in C works is
>>
>> - The start-up sequence does the repository discovery, which
>>involves crawling up to the top-level of the working tree, and
>>compute "prefix", w
Junio C Hamano writes:
> The way all the subcommand written in C works is
>
> - The start-up sequence does the repository discovery, which
>involves crawling up to the top-level of the working tree, and
>compute "prefix", where the end-user was when the command was
>invoked;
>
> - T
On Fri, Mar 25, 2016 at 10:01 AM, Junio C Hamano wrote:
> Stefan Beller writes:
>
>> The other reason you gave below is also convincing: By having it in the
>> prefix,
>> the C code is more likely correct and future proof.
>>
>> On rewriting the whole submodule command in C (probably
>> reiterat
Stefan Beller writes:
> The other reason you gave below is also convincing: By having it in the
> prefix,
> the C code is more likely correct and future proof.
>
> On rewriting the whole submodule command in C (probably
> reiterating): It is not my endgoal to rewrite every submodule
> related pa
On Thu, Mar 24, 2016 at 11:28 PM, Junio C Hamano wrote:
>
> So this change may not be wrong per-se, but if the lossage of prefix
> is the final goal (as opposed to an approach to gain other benefits,
> e.g. "now we do not have to use prefix, we can simplify these other
> things"), I do not know if
Junio C Hamano writes:
> Stefan Beller writes:
>
>> The usual early machinery of Git is to change the directory to
>> the top level of the working tree and pass the actual path inside
>> the working tree as `prefix` to the command being run.
>>
>> This is the case both for commands written in C
Stefan Beller writes:
> The usual early machinery of Git is to change the directory to
> the top level of the working tree and pass the actual path inside
> the working tree as `prefix` to the command being run.
>
> This is the case both for commands written in C (where the
> prefix is passed int
On Thu, Mar 24, 2016 at 4:34 PM, Stefan Beller wrote:
> The usual early machinery of Git is to change the directory to
> the top level of the working tree and pass the actual path inside
> the working tree as `prefix` to the command being run.
> This is the case both for commands written in C (whe
The usual early machinery of Git is to change the directory to
the top level of the working tree and pass the actual path inside
the working tree as `prefix` to the command being run.
This is the case both for commands written in C (where the
prefix is passed into the command in a function paramete
10 matches
Mail list logo
