[PATCH 3/4] submodule--helper: fix BUG message in ensure_core_worktree

2018-12-14 Thread Stefan Beller
74d4731da1 (submodule--helper: replace connect-gitdir-workingtree by ensure-core-worktree, 2018-08-13) missed to update the BUG message. Fix it. Signed-off-by: Stefan Beller --- builtin/submodule--helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/submodule--hel

Re: [PATCH 3/4] submodule--helper: fix BUG message in ensure_core_worktree

2018-12-12 Thread Junio C Hamano
Stefan Beller writes: >> Unlike the step 2/4 I commented on, this does explain what this >> wants to do and why, at least when looked from sideways. Is the >> above saying the same as the following two-liner? >> >> An ealier mistake while rebasing to produce 74d4731da1 >> failed

Re: [PATCH 3/4] submodule--helper: fix BUG message in ensure_core_worktree

2018-12-12 Thread Stefan Beller
> Unlike the step 2/4 I commented on, this does explain what this > wants to do and why, at least when looked from sideways. Is the > above saying the same as the following two-liner? > > An ealier mistake while rebasing to produce 74d4731da1 > failed to update this BUG message. F

Re: [PATCH 3/4] submodule--helper: fix BUG message in ensure_core_worktree

2018-12-07 Thread Junio C Hamano
Stefan Beller writes: > Shortly after f178c13fda (Revert "Merge branch > 'sb/submodule-core-worktree'", 2018-09-07), we had another series > that implemented partially the same, ensuring that core.worktree was > set in a checked out submodule, namely 74d4731da1 (submodule--helper: > replace conne

[PATCH 3/4] submodule--helper: fix BUG message in ensure_core_worktree

2018-12-07 Thread Stefan Beller
Shortly after f178c13fda (Revert "Merge branch 'sb/submodule-core-worktree'", 2018-09-07), we had another series that implemented partially the same, ensuring that core.worktree was set in a checked out submodule, namely 74d4731da1 (submodule--helper: replace connect-gitdir-workingtree by ensure-co