Re: [PATCH 3/4] strbuf.h: format asciidoc code blocks as 4-space indent

2014-12-14 Thread Michael Haggerty
On 12/12/2014 11:39 PM, Jonathan Nieder wrote: > Jeff King wrote: > >> This is much easier to read when the whole thing is stuffed >> inside a comment block. And there is precedent for this >> convention in markdown (and just in general ascii text). >> >> Signed-off-by: Jeff King >> --- > > Revi

Re: [PATCH 3/4] strbuf.h: format asciidoc code blocks as 4-space indent

2014-12-12 Thread Jonathan Nieder
Jeff King wrote: > This is much easier to read when the whole thing is stuffed > inside a comment block. And there is precedent for this > convention in markdown (and just in general ascii text). > > Signed-off-by: Jeff King > --- Reviewed-by: Jonathan Nieder > As a side note, I actually find

[PATCH 3/4] strbuf.h: format asciidoc code blocks as 4-space indent

2014-12-12 Thread Jeff King
This is much easier to read when the whole thing is stuffed inside a comment block. And there is precedent for this convention in markdown (and just in general ascii text). Signed-off-by: Jeff King --- As a side note, I actually find markdown much more pleasant to read and write than asciidoc. I