Re: [PATCH 3/4] git-gui--askyesno: allow overriding the window title

2019-09-29 Thread Pratyush Yadav
One minor nitpick: please add a comment at the top of the file documenting the `--title` option, and the usage of the program in general. Other than that, looks good. Thanks. On 26/09/19 08:29AM, Johannes Schindelin via GitGitGadget wrote: > From: Johannes Schindelin > > "Question?" is maybe

[PATCH 3/4] git-gui--askyesno: allow overriding the window title

2019-09-26 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin "Question?" is maybe not the most informative thing to ask. In the absence of better information, it is the best we can do, of course. However, Git for Windows' auto updater just learned the trick to use git-gui--askyesno to ask the user whether to update now or not. An