Re: [PATCH 3/4] fast-export: don't parse all the commits

2013-05-04 Thread Junio C Hamano
Felipe Contreras writes: >> This updates the parse_object() moved by the previous patch. At this >> point in the codeflow, unlike the original, we already _know_ the >> object must be a commit; wouldn't an equivalent of: >> >> object = &(lookup_commit(sha1)->object) >> >> be more correct

Re: [PATCH 3/4] fast-export: don't parse all the commits

2013-05-03 Thread Felipe Contreras
On Fri, May 3, 2013 at 4:54 PM, Junio C Hamano wrote: > Felipe Contreras writes: > >> We don't need the parsed objects at this point, merely the information >> that they have marks. >> >> Seems to be three times faster in my setup with lots of objects. >> >> Signed-off-by: Felipe Contreras >> --

Re: [PATCH 3/4] fast-export: don't parse all the commits

2013-05-03 Thread Junio C Hamano
Felipe Contreras writes: > We don't need the parsed objects at this point, merely the information > that they have marks. > > Seems to be three times faster in my setup with lots of objects. > > Signed-off-by: Felipe Contreras > --- > builtin/fast-export.c | 2 +- > 1 file changed, 1 insertion(

[PATCH 3/4] fast-export: don't parse all the commits

2013-05-02 Thread Felipe Contreras
We don't need the parsed objects at this point, merely the information that they have marks. Seems to be three times faster in my setup with lots of objects. Signed-off-by: Felipe Contreras --- builtin/fast-export.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/fas