Re: [PATCH 3/4] exclude/attr: share basename matching code

2012-10-14 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > match_basename's declaration in dir.h does not have any description to > discourage the use of this function elsewhere as this function is > highly tied to how excluded_from_list and path_matches work. If you do want to discourage, please explicitly describe it as

[PATCH 3/4] exclude/attr: share basename matching code

2012-10-14 Thread Nguyễn Thái Ngọc Duy
match_basename's declaration in dir.h does not have any description to discourage the use of this function elsewhere as this function is highly tied to how excluded_from_list and path_matches work. Signed-off-by: Nguyễn Thái Ngọc Duy --- attr.c | 15 --- dir.c | 37 +