Re: [PATCH 3/4] describe: use argv-array

2013-07-09 Thread Jeff King
On Tue, Jul 09, 2013 at 09:00:20AM -0700, Junio C Hamano wrote: > >>> + return cmd_name_rev(args.argc, args.argv, prefix); > >> > >> This leaks the memory allocated by "args". The original did, too, and it > >> is probably not that big a deal (we exit right after anyway). The fix > >> woul

Re: [PATCH 3/4] describe: use argv-array

2013-07-09 Thread Junio C Hamano
Junio C Hamano writes: > Jeff King writes: > >> On Sun, Jul 07, 2013 at 03:33:43PM -0700, Junio C Hamano wrote: >> >>> + argv_array_init(&args); >>> + argv_array_push(&args, "name-rev"); >>> + argv_array_push(&args, "--name-only"); >>> + argv_array_push(&a

Re: [PATCH 3/4] describe: use argv-array

2013-07-09 Thread Junio C Hamano
Jeff King writes: > On Sun, Jul 07, 2013 at 03:33:43PM -0700, Junio C Hamano wrote: > >> +argv_array_init(&args); >> +argv_array_push(&args, "name-rev"); >> +argv_array_push(&args, "--name-only"); >> +argv_array_push(&args, "--no-undefined"); >> [..

Re: [PATCH 3/4] describe: use argv-array

2013-07-08 Thread Jeff King
On Sun, Jul 07, 2013 at 03:33:43PM -0700, Junio C Hamano wrote: > + argv_array_init(&args); > + argv_array_push(&args, "name-rev"); > + argv_array_push(&args, "--name-only"); > + argv_array_push(&args, "--no-undefined"); > [...] > - memcp

[PATCH 3/4] describe: use argv-array

2013-07-07 Thread Junio C Hamano
Instead of using a hand allocated args[] array, use argv-array API to manage the dynamically created list of arguments when invoking name-rev. Signed-off-by: Junio C Hamano --- builtin/describe.c | 31 --- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git