Re: [PATCH 3/4] Makefile: factor common configuration in git-default-config.mak

2013-02-08 Thread Matthieu Moy
Junio C Hamano writes: > I really think this is going in a wrong direction. Whatever you > happen to have chosen in this patch will be available to others, > while whatever are left out will not be. When adding new things, > people need to ask if it needs to be sharable or not, and the right >

Re: [PATCH 3/4] Makefile: factor common configuration in git-default-config.mak

2013-02-07 Thread Junio C Hamano
Matthieu Moy writes: > Similarly to the extraction of perl-related code in perl.mak, we extract > general default configuration from the Makefile to make it available from > directories other than the toplevel. > > This is required to make perl.mak usable because it requires $(pathsep) > to be se

[PATCH 3/4] Makefile: factor common configuration in git-default-config.mak

2013-02-06 Thread Matthieu Moy
Similarly to the extraction of perl-related code in perl.mak, we extract general default configuration from the Makefile to make it available from directories other than the toplevel. This is required to make perl.mak usable because it requires $(pathsep) to be set. Signed-off-by: Matthieu Moy -