Re: [PATCH 3/3] replace binary keyrings with armored keys

2014-12-13 Thread Christian Hesse
Junio C Hamano on Fri, 2014/12/12 13:50: > Christian Hesse writes: > > Last but not least git and patch can handle this a > > lot better. > > Actually we can handle binary patch just fine ;-) Ah, that was kind of misleading. :-p Generating a patch with git including binary data and trying to ap

Re: [PATCH 3/3] replace binary keyrings with armored keys

2014-12-12 Thread Junio C Hamano
Christian Hesse writes: > Importing PGP key public and security ring works, but this is supposed > for runtime. As name suggests we prefer exported format for import. > > The extra benefit is that we do not have all secret keys in one binary > blob and all public keys in another. Instead public a

[PATCH 3/3] replace binary keyrings with armored keys

2014-12-12 Thread Christian Hesse
Importing PGP key public and security ring works, but this is supposed for runtime. As name suggests we prefer exported format for import. The extra benefit is that we do not have all secret keys in one binary blob and all public keys in another. Instead public and secret keys for one key pair are

Re: [PATCH 3/3] replace binary keyrings with armored keys

2014-12-12 Thread Junio C Hamano
Christian Hesse writes: > Signed-off-by: Christian Hesse > --- Could you explain why it is a good idea to do this to the future readers of "git log" who encounter this change? Note that I do not have a particular objection to this change. If the original were using a single file as an import

[PATCH 3/3] replace binary keyrings with armored keys

2014-12-12 Thread Christian Hesse
Signed-off-by: Christian Hesse --- t/lib-gpg.sh | 3 +- t/lib-gpg/keyring.gpg | 88 ++ t/lib-gpg/pubring.gpg | Bin 2359 -> 0 bytes t/lib-gpg/secring.gpg | Bin 3734 -> 0 bytes 4 files changed, 89 insertions(+), 2 deletions(-) create mo