Re: [PATCH 3/3] read-cache: don't write index twice if we can't write shared index

2018-01-26 Thread Lars Schneider
> On 22 Jan 2018, at 19:27, SZEDER Gábor wrote: > > > On Thu, Jan 18, 2018 at 1:47 PM, Duy Nguyen wrote: >> On Thu, Jan 18, 2018 at 6:36 PM, SZEDER Gábor wrote: >>> This series, queued as 'nd/shared-index-fix', makes the 32 bit Linux >>> build job fail on Travis CI. Unfortunately, all it can

[PATCH 3/3] read-cache: don't write index twice if we can't write shared index

2018-01-24 Thread Nguyễn Thái Ngọc Duy
In a0a967568e ("update-index --split-index: do not split if $GIT_DIR is read only", 2014-06-13), we tried to make sure we can still write an index, even if the shared index can not be written. We did so by just calling 'do_write_locked_index()' just before 'write_shared_index()'. 'do_write_locked

Re: [PATCH 3/3] read-cache: don't write index twice if we can't write shared index

2018-01-24 Thread Duy Nguyen
On Tue, Jan 23, 2018 at 1:27 AM, SZEDER Gábor wrote: > > On Thu, Jan 18, 2018 at 1:47 PM, Duy Nguyen wrote: >> On Thu, Jan 18, 2018 at 6:36 PM, SZEDER Gábor wrote: >>> This series, queued as 'nd/shared-index-fix', makes the 32 bit Linux >>> build job fail on Travis CI. Unfortunately, all it can

Re: [PATCH 3/3] read-cache: don't write index twice if we can't write shared index

2018-01-22 Thread Duy Nguyen
On Tue, Jan 23, 2018 at 6:09 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> diff --git a/t/t1700-split-index.sh b/t/t1700-split-index.sh >> index af9b847761..d2a8e0312a 100755 >> --- a/t/t1700-split-index.sh >> +++ b/t/t1700-split-index.sh >> @@ -401,4 +401,23 @@ done <<\EOF >> 0

Re: [PATCH 3/3] read-cache: don't write index twice if we can't write shared index

2018-01-22 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > diff --git a/t/t1700-split-index.sh b/t/t1700-split-index.sh > index af9b847761..d2a8e0312a 100755 > --- a/t/t1700-split-index.sh > +++ b/t/t1700-split-index.sh > @@ -401,4 +401,23 @@ done <<\EOF > 0642 -rw-r---w- > EOF > > +test_expect_success SANITY 'graceful

Re: [PATCH 3/3] read-cache: don't write index twice if we can't write shared index

2018-01-22 Thread SZEDER Gábor
On Mon, Jan 22, 2018 at 8:46 PM, Eric Sunshine wrote: > On Mon, Jan 22, 2018 at 1:27 PM, SZEDER Gábor wrote: >> - The logs of OSX build jobs have CRCRLF line endings. However, the >> 'base64' util of OSX doesn't wrap its output at 76 columns, i.e. >> prints one single albeit very long

Re: [PATCH 3/3] read-cache: don't write index twice if we can't write shared index

2018-01-22 Thread Eric Sunshine
On Mon, Jan 22, 2018 at 1:27 PM, SZEDER Gábor wrote: > Subject: [PATCH] travis-ci: include the trash directories of failed tests in > the trace log > > The trash directory of a failed test might contain valuable > information about the cause of the failure, but we have no access to > the trash di

Re: [PATCH 3/3] read-cache: don't write index twice if we can't write shared index

2018-01-22 Thread SZEDER Gábor
On Thu, Jan 18, 2018 at 1:47 PM, Duy Nguyen wrote: > On Thu, Jan 18, 2018 at 6:36 PM, SZEDER Gábor wrote: >> This series, queued as 'nd/shared-index-fix', makes the 32 bit Linux >> build job fail on Travis CI. Unfortunately, all it can tell us about >> the failure is this: >> >> Test Summary

[PATCH 3/3] read-cache: don't write index twice if we can't write shared index

2018-01-22 Thread Nguyễn Thái Ngọc Duy
In a0a967568e ("update-index --split-index: do not split if $GIT_DIR is read only", 2014-06-13), we tried to make sure we can still write an index, even if the shared index can not be written. We did so by just calling 'do_write_locked_index()' just before 'write_shared_index()'. 'do_write_locked

Re: [PATCH 3/3] read-cache: don't write index twice if we can't write shared index

2018-01-18 Thread Duy Nguyen
On Fri, Jan 19, 2018 at 5:32 AM, SZEDER Gábor wrote: > On Thu, Jan 18, 2018 at 10:37 PM, Jeff King wrote: >> On Thu, Jan 18, 2018 at 10:00:14PM +0700, Duy Nguyen wrote: >> >>> The test suite was run as root, no wonder why my removing write access >>> has no effect. I got the test to pass with thi

Re: [PATCH 3/3] read-cache: don't write index twice if we can't write shared index

2018-01-18 Thread SZEDER Gábor
On Thu, Jan 18, 2018 at 10:37 PM, Jeff King wrote: > On Thu, Jan 18, 2018 at 10:00:14PM +0700, Duy Nguyen wrote: > >> The test suite was run as root, no wonder why my removing write access >> has no effect. I got the test to pass with this, but then it fails >> with >> >> Can't write .prove (P

Re: [PATCH 3/3] read-cache: don't write index twice if we can't write shared index

2018-01-18 Thread Jeff King
On Thu, Jan 18, 2018 at 10:00:14PM +0700, Duy Nguyen wrote: > The test suite was run as root, no wonder why my removing write access > has no effect. I got the test to pass with this, but then it fails > with > > Can't write .prove (Permission denied) at > /usr/share/perl/5.22/App/Prove.pm l

Re: [PATCH 3/3] read-cache: don't write index twice if we can't write shared index

2018-01-18 Thread Duy Nguyen
On Thu, Jan 18, 2018 at 08:36:32PM +0700, Duy Nguyen wrote: > On Thu, Jan 18, 2018 at 8:29 PM, Jeff King wrote: > > On Thu, Jan 18, 2018 at 07:47:50PM +0700, Duy Nguyen wrote: > > > >> I may need help getting that log (or even better the trash directory > >> of t1700). I tried -m32 build, then val

Re: [PATCH 3/3] read-cache: don't write index twice if we can't write shared index

2018-01-18 Thread Duy Nguyen
On Thu, Jan 18, 2018 at 8:29 PM, Jeff King wrote: > On Thu, Jan 18, 2018 at 07:47:50PM +0700, Duy Nguyen wrote: > >> I may need help getting that log (or even better the trash directory >> of t1700). I tried -m32 build, then valgrind on amd64 (because it >> didn't work with my 32 build), running t

Re: [PATCH 3/3] read-cache: don't write index twice if we can't write shared index

2018-01-18 Thread Jeff King
On Thu, Jan 18, 2018 at 07:47:50PM +0700, Duy Nguyen wrote: > I may need help getting that log (or even better the trash directory > of t1700). I tried -m32 build, then valgrind on amd64 (because it > didn't work with my 32 build), running the tests with dash and even > the linux32 docker version

Re: [PATCH 3/3] read-cache: don't write index twice if we can't write shared index

2018-01-18 Thread Duy Nguyen
On Thu, Jan 18, 2018 at 6:36 PM, SZEDER Gábor wrote: > This series, queued as 'nd/shared-index-fix', makes the 32 bit Linux > build job fail on Travis CI. Unfortunately, all it can tell us about > the failure is this: > > Test Summary Report > --- > t1700-split-index.sh

Re: [PATCH 3/3] read-cache: don't write index twice if we can't write shared index

2018-01-18 Thread SZEDER Gábor
This series, queued as 'nd/shared-index-fix', makes the 32 bit Linux build job fail on Travis CI. Unfortunately, all it can tell us about the failure is this: Test Summary Report --- t1700-split-index.sh (Wstat: 256 Tests: 23 Failed: 1) Fail

[PATCH 3/3] read-cache: don't write index twice if we can't write shared index

2018-01-14 Thread Nguyễn Thái Ngọc Duy
In a0a967568e ("update-index --split-index: do not split if $GIT_DIR is read only", 2014-06-13), we tried to make sure we can still write an index, even if the shared index can not be written. We did so by just calling 'do_write_locked_index()' just before 'write_shared_index()'. 'do_write_locked