Re: [PATCH 3/3] grep: stop using a custom JIT stack with PCRE v1

On Fri, Jul 26 2019, Carlo Arenas wrote: > On Fri, Jul 26, 2019 at 6:50 AM Ævar Arnfjörð Bjarmason > wrote: >> >> On Fri, Jul 26 2019, Carlo Arenas wrote: >> >> > since this moves PCRE1 out of the JIT fast path, >> >> I think you're mostly replying to the wrong thread. None of the patches >> I'

Re: [PATCH 3/3] grep: stop using a custom JIT stack with PCRE v1

On Fri, Jul 26, 2019 at 6:50 AM Ævar Arnfjörð Bjarmason wrote: > > On Fri, Jul 26 2019, Carlo Arenas wrote: > > > since this moves PCRE1 out of the JIT fast path, > > I think you're mostly replying to the wrong thread. None of the patches > I've sent disable PCRE v1 JIT, as the performance numbers

Re: [PATCH 3/3] grep: stop using a custom JIT stack with PCRE v1

On Fri, Jul 26 2019, Carlo Arenas wrote: > since this moves PCRE1 out of the JIT fast path, I think you're mostly replying to the wrong thread. None of the patches I've sent disable PCRE v1 JIT, as the performance numbers show. The JIT stack is resized, and for v2 some dead code removed. > int

Re: [PATCH 3/3] grep: stop using a custom JIT stack with PCRE v1

since this moves PCRE1 out of the JIT fast path, introduces the regression where git grep will abort if there is binary data or non UTF-8 text in the repository/log and should be IMHO hold out until a fix for that can be merged. this also needs additional changes to better support NO_LIBPCRE1_JIT,

[PATCH 3/3] grep: stop using a custom JIT stack with PCRE v1

Simplify the PCRE v1 code for the same reasons as for the PCRE v2 code in the last commit. Unlike with v2 we actually used the custom stack in v1, but let's use PCRE's built-in 32 KB one instead, since experience with v2 shows that's enough. Most distros are already using v2 as a default, and the u