Re: [PATCH 3/3] doc: give examples for send-email cc-cmd operation

2015-07-22 Thread Junio C Hamano
"Philip Oakley" writes: >> It is an >> unacceptable hack for us to encourage in the longer term. It may >> happen to work with the current implementation, but it does so >> merely by depending on the implementation too much. >> >> If it is so common to want to spray all your patches to exactly

Re: [PATCH 3/3] doc: give examples for send-email cc-cmd operation

2015-07-21 Thread Philip Oakley
From: "Junio C Hamano" Junio C Hamano writes: I was trying to use, essentially, 'cat list.txt' as the command,... One thing that needs to be made clear is that I do not think we want to encourage `cat list.txt #` abuse in the first place. OK [1] It is an unacceptable hack for us to en

Re: [PATCH 3/3] doc: give examples for send-email cc-cmd operation

2015-07-20 Thread Junio C Hamano
Junio C Hamano writes: >> I was trying to use, essentially, 'cat list.txt' as the command,... One thing that needs to be made clear is that I do not think we want to encourage `cat list.txt #` abuse in the first place. It is an unacceptable hack for us to encourage in the longer term. It may h

Re: [PATCH 3/3] doc: give examples for send-email cc-cmd operation

2015-07-20 Thread Junio C Hamano
"Philip Oakley" writes: > We seem to be going round in circles. I do not think so. > Currently the --cc-cmd isn't well documented. Yes, I agree. > I was trying to use, essentially, 'cat list.txt' as the command, which > should work according to the current doc, which says nothing about > how/

Re: [PATCH 3/3] doc: give examples for send-email cc-cmd operation

2015-07-20 Thread Philip Oakley
From: "Junio C Hamano" Philip Oakley writes: +git-send-email invokes the cc-cmd like this: + + $cc-cmd $patchfilename + +Thus the patch itself can be processed to locate appropriate email address +information if required. That's not even a valid command line (cc-cmd cannot be a shell vari

Re: [PATCH 3/3] doc: give examples for send-email cc-cmd operation

2015-07-20 Thread Eric Sunshine
On Mon, Jul 20, 2015 at 3:36 PM, Philip Oakley wrote: > From: "Eric Sunshine" >>> + echo <<\EOF >>> + pers...@example.com >>> + pers...@example.com >>> + EOF >> >> I don't know if it deserves mention that the script must be executable >> (chmod +x) or should we assume that

Re: [PATCH 3/3] doc: give examples for send-email cc-cmd operation

2015-07-20 Thread Eric Sunshine
On Mon, Jul 20, 2015 at 3:14 PM, Eric Sunshine wrote: > If you really want to give an example of how to use --cc-cmd > (--to-cmd) with a plain text file holding email addresses, maybe > something like this instead: > > Create an EXAMPLES section. > > Make the bare-bones, static address list script

Re: [PATCH 3/3] doc: give examples for send-email cc-cmd operation

2015-07-20 Thread Junio C Hamano
Philip Oakley writes: > +git-send-email invokes the cc-cmd like this: > + > + $cc-cmd $patchfilename > + > +Thus the patch itself can be processed to locate appropriate email address > +information if required. That's not even a valid command line (cc-cmd cannot be a shell variable name), so

Re: [PATCH 3/3] doc: give examples for send-email cc-cmd operation

2015-07-20 Thread Philip Oakley
From: "Eric Sunshine" On Mon, Jul 20, 2015 at 2:26 PM, Philip Oakley wrote: Explain how the cc-cmd (and to-cmd) is invoked, along with two simple examples (and a how-not-to example) to help in getting started. Helped-by: Eric Sunshine Signed-off-by: Philip Oakley --- diff --git a/Document

Re: [PATCH 3/3] doc: give examples for send-email cc-cmd operation

2015-07-20 Thread Eric Sunshine
On Mon, Jul 20, 2015 at 2:50 PM, Eric Sunshine wrote: > On Mon, Jul 20, 2015 at 2:26 PM, Philip Oakley wrote: >> Explain how the cc-cmd (and to-cmd) is invoked, along with two >> simple examples (and a how-not-to example) to help in getting started. >> >> Helped-by: Eric Sunshine >> Signed-off-b

Re: [PATCH 3/3] doc: give examples for send-email cc-cmd operation

2015-07-20 Thread Eric Sunshine
On Mon, Jul 20, 2015 at 2:26 PM, Philip Oakley wrote: > Explain how the cc-cmd (and to-cmd) is invoked, along with two > simple examples (and a how-not-to example) to help in getting started. > > Helped-by: Eric Sunshine > Signed-off-by: Philip Oakley > --- > diff --git a/Documentation/git-send-

[PATCH 3/3] doc: give examples for send-email cc-cmd operation

2015-07-20 Thread Philip Oakley
Explain how the cc-cmd (and to-cmd) is invoked, along with two simple examples (and a how-not-to example) to help in getting started. Helped-by: Eric Sunshine Signed-off-by: Philip Oakley --- http://article.gmane.org/gmane.comp.version-control.git/274302 --- Documentation/git-send-email.txt | 3