Re: [PATCH 3/3] difftool: use Git::* functions instead of passing around state

2016-07-19 Thread Junio C Hamano
David Aguilar writes: > Call Git::command() and friends directly wherever possible. > This makes it clear that these operations can be invoked directly > without needing to manage the current directory and related GIT_* > environment variables. Good. > @@ -88,11 +80,11 @@ sub changed_files >

[PATCH 3/3] difftool: use Git::* functions instead of passing around state

2016-07-18 Thread David Aguilar
Call Git::command() and friends directly wherever possible. This makes it clear that these operations can be invoked directly without needing to manage the current directory and related GIT_* environment variables. Eliminate find_repository() since we can now use wc_path() and not worry about side