Re: [PATCH 3/3] diff: use skip_to_opt_val()

2017-12-06 Thread Christian Couder
On Thu, Dec 7, 2017 at 1:18 AM, Jacob Keller wrote: > On Wed, Dec 6, 2017 at 4:16 PM, Jacob Keller wrote: >> >> This causes a regression in the --relative option which prevents it >> from working properly. >> >> If I have a repository with a modified file in a subdirectory, such as: >> >> a/file

Re: [PATCH 3/3] diff: use skip_to_opt_val()

2017-12-06 Thread Jacob Keller
On Wed, Dec 6, 2017 at 4:16 PM, Jacob Keller wrote: > On Sun, Dec 3, 2017 at 9:04 AM, Christian Couder > wrote: >> From: Christian Couder >> >> Let's simplify diff option parsing using skip_to_opt_val(). >> >> Signed-off-by: Christian Couder >> --- >> diff.c | 22 -- >> 1 f

Re: [PATCH 3/3] diff: use skip_to_opt_val()

2017-12-06 Thread Jacob Keller
On Sun, Dec 3, 2017 at 9:04 AM, Christian Couder wrote: > From: Christian Couder > > Let's simplify diff option parsing using skip_to_opt_val(). > > Signed-off-by: Christian Couder > --- > diff.c | 22 -- > 1 file changed, 8 insertions(+), 14 deletions(-) > > diff --git a/di

[PATCH 3/3] diff: use skip_to_opt_val()

2017-12-03 Thread Christian Couder
From: Christian Couder Let's simplify diff option parsing using skip_to_opt_val(). Signed-off-by: Christian Couder --- diff.c | 22 -- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/diff.c b/diff.c index 2ebe2227b4..067b498187 100644 --- a/diff.c +++ b/diff.