Re: [PATCH 3/3] diff: convert flags to be stored in bitfields

2017-10-30 Thread Junio C Hamano
Junio C Hamano writes: > Junio C Hamano writes: > >> I still haven't brought myself to like the structure being passed by >> value and the singleton diff_flags_cleared thing, but I suspect that >> we may get used to them once we start using these. I dunno. > > Just bikeshedding, but I just had

Re: [PATCH 3/3] diff: convert flags to be stored in bitfields

2017-10-30 Thread Brandon Williams
On 10/30, Junio C Hamano wrote: > Junio C Hamano writes: > > > I still haven't brought myself to like the structure being passed by > > value and the singleton diff_flags_cleared thing, but I suspect that > > we may get used to them once we start using these. I dunno. > > Just bikeshedding, but

Re: [PATCH 3/3] diff: convert flags to be stored in bitfields

2017-10-30 Thread Brandon Williams
On 10/29, Junio C Hamano wrote: > Brandon Williams writes: > > > We have have reached the limit of the number of flags that can be stored > > s/have have/have/; but bit #9 is unused. > > "We cannot add many more flags even if we wanted to" would be more > flexible and does not take this chang

Re: [PATCH 3/3] diff: convert flags to be stored in bitfields

2017-10-29 Thread Junio C Hamano
Junio C Hamano writes: > I still haven't brought myself to like the structure being passed by > value and the singleton diff_flags_cleared thing, but I suspect that > we may get used to them once we start using these. I dunno. Just bikeshedding, but I just had to prepare an evil merge to add a

Re: [PATCH 3/3] diff: convert flags to be stored in bitfields

2017-10-28 Thread Junio C Hamano
Brandon Williams writes: > We have have reached the limit of the number of flags that can be stored s/have have/have/; but bit #9 is unused. "We cannot add many more flags even if we wanted to" would be more flexible and does not take this change hostage to whatever topic that tries to claim

[PATCH 3/3] diff: convert flags to be stored in bitfields

2017-10-27 Thread Brandon Williams
We have have reached the limit of the number of flags that can be stored in a single unsigned int. In order to allow for more flags to be added to the diff machinery in the future this patch converts the flags to be stored in bitfields in 'struct diff_flags'. Signed-off-by: Brandon Williams ---