Re: [PATCH 3/3] clone: auto-enable git-credential-store when necessary

2019-05-20 Thread Ævar Arnfjörð Bjarmason
On Sun, May 19 2019, Jeff King wrote: > If the user clones with a URL containing a password and has no > credential helper configured, we're stuck. We don't want to write the > password into .git/config because that risks accidentally disclosing it. > But if we don't record it somewhere, subsequ

Re: [PATCH 3/3] clone: auto-enable git-credential-store when necessary

2019-05-20 Thread Johannes Schindelin
Hi Peff, On Mon, 20 May 2019, Jeff King wrote: > On Mon, May 20, 2019 at 07:28:08AM -0400, Eric Sunshine wrote: > > > > The biggest downside is that it's a bit magical from the user's > > > perspective, because now the password is off in some other file > > > (usually ~/.git-credentials, but some

Re: [PATCH 3/3] clone: auto-enable git-credential-store when necessary

2019-05-20 Thread Jeff King
On Mon, May 20, 2019 at 05:17:20PM +0200, Ævar Arnfjörð Bjarmason wrote: > > There are more cases beyond that, too. You might have a helper defined > > which doesn't actually store passwords, but just sometimes tries to > > provide one. My thinking was that if you're clueful enough to have > > con

Re: [PATCH 3/3] clone: auto-enable git-credential-store when necessary

2019-05-20 Thread Ævar Arnfjörð Bjarmason
On Mon, May 20 2019, Jeff King wrote: > On Mon, May 20, 2019 at 03:56:14PM +0200, Ævar Arnfjörð Bjarmason wrote: > >> > -test_expect_failure 'fetch of password-URL clone uses stored auth' ' >> > +test_expect_success 'fetch of password-URL clone uses stored auth' ' >> >set_askpass wrong && >>

Re: [PATCH 3/3] clone: auto-enable git-credential-store when necessary

2019-05-20 Thread Jeff King
On Mon, May 20, 2019 at 03:56:14PM +0200, Ævar Arnfjörð Bjarmason wrote: > > -test_expect_failure 'fetch of password-URL clone uses stored auth' ' > > +test_expect_success 'fetch of password-URL clone uses stored auth' ' > > set_askpass wrong && > > git -C clone-auth-none fetch && > >

Re: [PATCH 3/3] clone: auto-enable git-credential-store when necessary

2019-05-20 Thread Ævar Arnfjörð Bjarmason
On Sun, May 19 2019, Jeff King wrote: > If the user clones with a URL containing a password and has no > credential helper configured, we're stuck. We don't want to write the > password into .git/config because that risks accidentally disclosing it. > But if we don't record it somewhere, subsequ

Re: [PATCH 3/3] clone: auto-enable git-credential-store when necessary

2019-05-20 Thread Jeff King
On Mon, May 20, 2019 at 07:28:08AM -0400, Eric Sunshine wrote: > > The biggest downside is that it's a bit magical from the user's > > perspective, because now the password is off in some other file (usually > > ~/.git-credentials, but sometimes in $XDG_CONFIG_HOME). Which > > complicates things i

Re: [PATCH 3/3] clone: auto-enable git-credential-store when necessary

2019-05-20 Thread Eric Sunshine
On Sun, May 19, 2019 at 2:42 PM Jeff King wrote: > If the user clones with a URL containing a password and has no > credential helper configured, we're stuck. We don't want to write the > password into .git/config because that risks accidentally disclosing it. > But if we don't record it somewhere

[PATCH 3/3] clone: auto-enable git-credential-store when necessary

2019-05-19 Thread Jeff King
If the user clones with a URL containing a password and has no credential helper configured, we're stuck. We don't want to write the password into .git/config because that risks accidentally disclosing it. But if we don't record it somewhere, subsequent fetches will fail unless the user is there to