Re: [PATCH 3/3] bisect: make diff-tree output prettier

2019-03-03 Thread Christian Couder
On Sat, Feb 23, 2019 at 2:44 PM Jeff King wrote: > > On Fri, Feb 22, 2019 at 09:49:44AM -0800, Junio C Hamano wrote: > > > > If we do care about the change in exit code from bisect, then it > > > probably does make sense to go with an external process. Then it can > > > happily die on the corrupt

Re: [PATCH 3/3] bisect: make diff-tree output prettier

2019-02-23 Thread Jeff King
On Fri, Feb 22, 2019 at 09:49:44AM -0800, Junio C Hamano wrote: > > Even though bisect might be driven by scripts, there's no reason to > > consider this part of the output as machine-readable (if anything, the > > initial "$hash is the first bad commit" might be parsed, but we won't > > touch tha

Re: [PATCH 3/3] bisect: make diff-tree output prettier

2019-02-22 Thread Junio C Hamano
Jeff King writes: > After completing a bisection, we print out the commit we found using an > internal version of diff-tree. The result is aesthetically lacking: > > - it shows a raw diff, which is generally less informative for human > readers than "--stat --summary" (which we already deci

[PATCH 3/3] bisect: make diff-tree output prettier

2019-02-21 Thread Jeff King
After completing a bisection, we print out the commit we found using an internal version of diff-tree. The result is aesthetically lacking: - it shows a raw diff, which is generally less informative for human readers than "--stat --summary" (which we already decided was nice for humans i