Adam Spiers writes:
> Fair enough, but let's not allow perfect to become the enemy of good.
That is why I would prefer a solution without any false positive
while allowing false negatives, i.e. not force everybody to use
these flags without giving a way to turn them off.
You could perhaps sell
On Mon, Dec 17, 2012 at 4:18 AM, Junio C Hamano wrote:
> Adam Spiers writes:
>
>> OK; I expect these issues with the implementation are all
>> surmountable. I did not necessarily expect this to be the final
>> implementation anyhow, as indicated by my comments below the divider
>> line. However
Adam Spiers writes:
> OK; I expect these issues with the implementation are all
> surmountable. I did not necessarily expect this to be the final
> implementation anyhow, as indicated by my comments below the divider
> line. However it's not clear to me what you think about the idea in
> princi
On Sun, Dec 16, 2012 at 05:52:05PM -0800, Junio C Hamano wrote:
> Adam Spiers writes:
>
> > If we adopt this approach,...
> > diff --git a/Makefile b/Makefile
> > index a49d1db..aae70d4 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -331,8 +331,13 @@ endif
> > # CFLAGS and LDFLAGS are for t
Adam Spiers writes:
> If we adopt this approach,...
> diff --git a/Makefile b/Makefile
> index a49d1db..aae70d4 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -331,8 +331,13 @@ endif
> # CFLAGS and LDFLAGS are for the users to override from the command line.
>
> CFLAGS = -g -O2 -Wall
> +GCC_DE
CodingGuidelines requests that code should be nice to older C compilers.
Since modern gcc can warn on code written using newer dialects such as C99,
it makes sense to take advantage of this by auto-detecting this capability
and enabling it when found.
Signed-off-by: Adam Spiers
---
If we adopt th
6 matches
Mail list logo