Re: [PATCH 3/3] Avoid non-portable strftime format specifiers in git-cvsimport

2013-02-09 Thread Junio C Hamano
Ben Walton writes: > Neither %s or %z are portable strftime format specifiers. Well, at least %z is in POSIX; "Some implementations of strftime(3) lack support for %z format" is fine, tough. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to ma

[PATCH 3/3] Avoid non-portable strftime format specifiers in git-cvsimport

2013-02-09 Thread Ben Walton
Neither %s or %z are portable strftime format specifiers. There is no need for %s in git-cvsimport as the supplied time is already in seconds since the epoch. For %z, use the function get_tz_offset provided by Git.pm instead. Signed-off-by: Ben Walton --- git-cvsimport.perl |5 - 1 fil

Re: [PATCH 3/3] Avoid non-portable strftime format specifiers in git-cvsimport

2013-01-16 Thread Ben Walton
On Wed, Jan 16, 2013 at 1:53 AM, Chris Rorvick wrote: > On Tue, Jan 15, 2013 at 5:10 PM, Ben Walton wrote: >> Neither %s or %z are portable strftime format specifiers. There is no >> need for %s in git-cvsimport as the supplied time is already in >> seconds since the epoch. For %z, use the func

Re: [PATCH 3/3] Avoid non-portable strftime format specifiers in git-cvsimport

2013-01-15 Thread Chris Rorvick
On Tue, Jan 15, 2013 at 5:10 PM, Ben Walton wrote: > Neither %s or %z are portable strftime format specifiers. There is no > need for %s in git-cvsimport as the supplied time is already in > seconds since the epoch. For %z, use the function get_tz_offset > provided by Git.pm instead. Out of cur

[PATCH 3/3] Avoid non-portable strftime format specifiers in git-cvsimport

2013-01-15 Thread Ben Walton
Neither %s or %z are portable strftime format specifiers. There is no need for %s in git-cvsimport as the supplied time is already in seconds since the epoch. For %z, use the function get_tz_offset provided by Git.pm instead. Signed-off-by: Ben Walton --- git-cvsimport.perl |5 - 1 fil