Re: [PATCH 2.5/4] diff: avoid returning a struct by value from diff_flags_or()

On 10/31, Junio C Hamano wrote: > That is more in line with the design decision made in the previous > step to pass struct by reference. > > We may want to squash this into the previous patch eventually. Looks good to me. I was on the fence with what to do since I was already moving to pass by r

[PATCH 2.5/4] diff: avoid returning a struct by value from diff_flags_or()

That is more in line with the design decision made in the previous step to pass struct by reference. We may want to squash this into the previous patch eventually. Signed-off-by: Junio C Hamano --- * I am OK either way as long as things are consistent; as you took time to change the code to