Re: [PATCH 2/9] ci/lib.sh: encapsulate Travis-specific things

2018-09-14 Thread Johannes Schindelin
Hi Sebastian, On Wed, 5 Sep 2018, Sebastian Schuberth wrote: > On 9/3/2018 11:10 PM, Johannes Schindelin via GitGitGadget wrote: > > > +if test -n "$TRAVIS_COMMIT" > > +then > > + # We are running within Travis CI > > Personally, I'd find a check like > > if test "$TRAVIS" = "true" > > more

Re: [PATCH 2/9] ci/lib.sh: encapsulate Travis-specific things

2018-09-05 Thread Sebastian Schuberth
On 9/3/2018 11:10 PM, Johannes Schindelin via GitGitGadget wrote: +if test -n "$TRAVIS_COMMIT" +then + # We are running within Travis CI Personally, I'd find a check like if test "$TRAVIS" = "true" more speaking (also see [1]). [1] https://docs.travis-ci.com/user/environment-variables

Re: [PATCH 2/9] ci/lib.sh: encapsulate Travis-specific things

2018-09-04 Thread Johannes Schindelin
Hi Eric, On Mon, 3 Sep 2018, Eric Sunshine wrote: > On Mon, Sep 3, 2018 at 5:10 PM Johannes Schindelin via GitGitGadget > wrote: > > The upcoming patches will allow building git.git via VSTS CI, where > > variable names and URLs look a bit different than in Travis CI. > > > > Signed-off-by: Joha

Re: [PATCH 2/9] ci/lib.sh: encapsulate Travis-specific things

2018-09-03 Thread Eric Sunshine
On Mon, Sep 3, 2018 at 5:10 PM Johannes Schindelin via GitGitGadget wrote: > The upcoming patches will allow building git.git via VSTS CI, where > variable names and URLs look a bit different than in Travis CI. > > Signed-off-by: Johannes Schindelin > --- > diff --git a/ci/install-dependencies.sh

[PATCH 2/9] ci/lib.sh: encapsulate Travis-specific things

2018-09-03 Thread Johannes Schindelin via GitGitGadget
From: Johannes Schindelin The upcoming patches will allow building git.git via VSTS CI, where variable names and URLs look a bit different than in Travis CI. Signed-off-by: Johannes Schindelin --- ci/install-dependencies.sh | 3 ++- ci/lib.sh | 44 +++-