Re: [PATCH 2/8] upload-pack: implement ref-in-want

2018-06-06 Thread Brandon Williams
On 06/07, Ævar Arnfjörð Bjarmason wrote: > > On Wed, Jun 06 2018, Brandon Williams wrote: > > > On 06/05, Ævar Arnfjörð Bjarmason wrote: > >> > >> On Tue, Jun 05 2018, Brandon Williams wrote: > >> > >> > +uploadpack.allowRefInWant:: > >> > +If this option is set, `upload-pack` will suppor

Re: [PATCH 2/8] upload-pack: implement ref-in-want

2018-06-06 Thread Ævar Arnfjörð Bjarmason
On Wed, Jun 06 2018, Brandon Williams wrote: > On 06/05, Ævar Arnfjörð Bjarmason wrote: >> >> On Tue, Jun 05 2018, Brandon Williams wrote: >> >> > +uploadpack.allowRefInWant:: >> > + If this option is set, `upload-pack` will support the `ref-in-want` >> > + feature of the protocol version 2 `f

Re: [PATCH 2/8] upload-pack: implement ref-in-want

2018-06-06 Thread Brandon Williams
On 06/05, Ævar Arnfjörð Bjarmason wrote: > > On Tue, Jun 05 2018, Brandon Williams wrote: > > > +uploadpack.allowRefInWant:: > > + If this option is set, `upload-pack` will support the `ref-in-want` > > + feature of the protocol version 2 `fetch` command. > > + > > I think it makes sense to

Re: [PATCH 2/8] upload-pack: implement ref-in-want

2018-06-05 Thread Ævar Arnfjörð Bjarmason
On Tue, Jun 05 2018, Brandon Williams wrote: > +uploadpack.allowRefInWant:: > + If this option is set, `upload-pack` will support the `ref-in-want` > + feature of the protocol version 2 `fetch` command. > + I think it makes sense to elaborate a bit on what this is for. Having read this

Re: [PATCH 2/8] upload-pack: implement ref-in-want

2018-06-05 Thread Ramsay Jones
On 05/06/18 18:51, Brandon Williams wrote: > Currently, while performing packfile negotiation, clients are only > allowed to specify their desired objects using object ids. This causes > a vulnerability to failure when an object turns non-existent during > negotiation, which may happen if, for

[PATCH 2/8] upload-pack: implement ref-in-want

2018-06-05 Thread Brandon Williams
Currently, while performing packfile negotiation, clients are only allowed to specify their desired objects using object ids. This causes a vulnerability to failure when an object turns non-existent during negotiation, which may happen if, for example, the desired repository is provided by multipl